Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove metadata from images #5122

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Remove metadata from images #5122

merged 1 commit into from
Jun 26, 2023

Conversation

taitus
Copy link
Member

@taitus taitus commented Jun 5, 2023

Objectives

Remove metadata from images.

Currently in the application we never show the original image, we always show one of its variants.

This change removes the metadata of both the variants and the original version so that if at some point we decide to show the original version, we will no longer have to remember to remove the metadata.

@javierm javierm added this to Reviewing in Consul Democracy Jun 5, 2023
@javierm javierm changed the title Removing metadata from images Remove metadata from images Jun 6, 2023
@javierm javierm added the security Pull requests that address a security vulnerability label Jun 7, 2023
@javierm javierm moved this from Reviewing to Doing in Consul Democracy Jun 8, 2023
@javierm javierm self-assigned this Jun 8, 2023
Currently in the application we never show the original image, we always
show one of its variants.

This change removes the metadata of both the variants and the original
version so that if at some point we decide to show the original version,
we will no longer have to remember to remove the metadata.
@taitus taitus moved this from Doing to Reviewing in Consul Democracy Jun 13, 2023
Consul Democracy automation moved this from Reviewing to Testing Jun 26, 2023
@taitus taitus merged commit bb8759d into master Jun 26, 2023
13 checks passed
Consul Democracy automation moved this from Testing to Release 2.0.0 Jun 26, 2023
@taitus taitus deleted the strip-metadata branch June 26, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security Pull requests that address a security vulnerability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants