Render markdown tables in legislation draft

[karim-semmoud]

Reference

Markdown not rendering correctly #5135

Objectives

This pull request aims at fixing the display of tables in the Legislation Draft from as a user, it also add test in order to make sure that the tables are rendered.

1- Allow table tags in Admin Legislation Sanitizer

2- Add Tables option to Redcarpet in Legislation draft
We used render_options and extensions variable in order to align with the existing code at app/helpers/application_helper.rb

3- Add custom CSS for Table inside Legislation draft using global table variables. we also make the table responsive with scrolling

4- Add Test to render markdown tables in Legislation drafts as a user and as an admin

5- Add Test for Admin Legislation Sanitizer. We also strengthen allowed and not allowed parameters

Visual Changes

Notes

• See Redcarpet for more options

[taitus]

Hi, @karim-semmoud

Thanks a lot for this pull request! 🎉

I've left a couple of comments. Let me know what you think!

[karim-semmoud]

Hi @taitus
Thank you for the review and comments.

1 -How about using click_link "Launch text editor" instead of click_link class: "fullscreen-toggle" in this test?
I agree, I will make the changes

2 -At Consul we try to avoid putting comments in the code, the commit message might be a good place to add this reference to the options offered by RedCarpet thinking
My bad, I copied the code from app/helpers/application_helper.rb without removing the comment line.
I also removed the comment line from application_helper.rb if that is ok

3-Table CSS
I agree with you , it makes more sense and keep consistency in the code

I will make the changes necessary and commit them

Extra Note:
Regarding the CSS for the Legislation draft, we may need in the future to use custom CSS for all the element inside Legislation Draft.
If an installation uses "fancy" colors for the text, table, headings ( for example pink on black ), I don't think it is a good idea to reuse the same CSS inside the Legislation Draft as it is supposed to look neutral and "official".
Ideally we would set neutral and "official document "looking font family, size, colors, headings, tables, links etc ...
Currently we only set the background color to white, but use the main body color etc ...
But I guess this is a discussion to be continued on a different pull request

[javierm]

I copied the code from app/helpers/application_helper.rb

This comment made me wonder why we've got two different ways of rendering markdown, with only one of them enabling certain extensions. Maybe it made sense before we stopped storing the generated HTML in the database but, if so, I think we can now unify the code 🤔.

@karim-semmoud @taitus Do you think it'd make sense? Here are a couple of commits that make the Legislation::DraftVersion model use the same code as the markdown helper. @karim-semmoud If you think this is a good idea, could you add them to this pull request (using git am <file>)?

0001-Use-the-same-extensions-in-all-markdown-renderers.txt
0002-Extract-markdown-helper-logic-to-a-class.txt

[javierm]

@karim-semmoud I've left a small comment; other than that, could you squash the first four commits of this pull request (all the commits except the ones I've posted in another comment) into one, since there are three commits that basically fix the first one?

Thanks a lot!

[karim-semmoud]

@javierm
I applied and pushed your 2 commits as you advised
I also squashed my previous commits into a single one
Let me know if there is anything else needed

[javierm]

@karim-semmoud Once again, thank you very much for your contributions!