Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh CSRF Token when using Turbolinks #5329

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

Senen
Copy link
Member

@Senen Senen commented Nov 30, 2023

References

This PR fixes:

Objectives

Refresh the authenticity token when browsing the application with Turbolinks.

Notes

We cannot reproduce the error in the test or development environment. So, we cannot write a test that demonstrates it. We verified manually that this commit fixes the problem described in #5160 when running the application in staging or production environments.

@javierm javierm added this to Reviewing in Consul Democracy Nov 30, 2023
@Senen Senen added the 2.1 label Nov 30, 2023
@javierm javierm added the Bug label Nov 30, 2023
@Senen Senen force-pushed the turbolinks_authenticity_token branch from f68e6f6 to 60a0fcf Compare November 30, 2023 17:57
Copy link
Member

@javierm javierm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🎉

Consul Democracy automation moved this from Reviewing to Testing Dec 1, 2023
@Senen Senen merged commit 49b3029 into master Dec 1, 2023
13 checks passed
Consul Democracy automation moved this from Testing to Release 2.1.0 Dec 1, 2023
@Senen Senen deleted the turbolinks_authenticity_token branch December 1, 2023 12:00
@javierm javierm removed the 2.1 label Dec 1, 2023
@javierm javierm linked an issue Dec 1, 2023 that may be closed by this pull request
@javierm javierm self-assigned this Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InvalidAuthenticityToken when voting a comment
3 participants