Update screenshots path in GitHub Actions #5577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
capybara_screenshots_path
branch
from
1404309
to
5e252e0
Compare
Since we upgraded to Rails 7.0 in commmit 8596f15, the screenshots started to be stored in `tmp/capybara`, so the step uploading screenshots wasn't doing anything.
javierm
force-pushed
the
capybara_screenshots_path
branch
from
5e252e0
to
37c9e6b
Compare
The upload-artifact action does not support using the same artifact name in different jobs (or in different matrix scenarios) since version 4, which we started using in commit acfaada. That meant that screenshots were not uploaded correctly when two or more knapsack nodes failed.
taitus
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives