feat:optional custom domain for zoro&gogo #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now this a very important PR, ability to have custom baseURL. |
Yes ofc, please tag owners to bring this into their acknowledgement. Thank you. |
riimuru
approved these changes
May 4, 2024
|
@riimuru if no issues please publish the repo as well so that latest changes can be used in package. |
This was referenced Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Its a feature and bug resolver, for cases when the streaming service changes their domain, and we have to wait untill someone statically replaces the old domain. It provides facility to add custom domain to zoro and gogoanime .
Before this commit , the test for gogoanime was failing for all 12 test cases, not its passing for 11 test cases. results are same for every other test. you may merge and check as well.
(if any code quality issue is there forgive me, first contribution, I have checked locally, Its working)
This commit resolves the issue #525