Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.0.10 #49

Merged
merged 1 commit into from
Apr 20, 2016
Merged

Release 0.0.10 #49

merged 1 commit into from
Apr 20, 2016

Conversation

dtolnay
Copy link
Contributor

@dtolnay dtolnay commented Apr 19, 2016

This is blocking serde-rs/serde#269

@FlashCat
Copy link
Contributor

r? @apasel422

(I've picked a reviewer for you, use r? to override)

@apasel422
Copy link
Contributor

I'll publish to crates.io later on, but how exactly is this blocking that issue?

@dtolnay
Copy link
Contributor Author

dtolnay commented Apr 20, 2016

Thanks Andrew. The Serde serialization/deserialization for linked-hash-map (#48) was added after the release of 0.0.9, so it has not been in any linked-hash-map release yet. For serde-rs/serde#269 we need a dependency on a map type that preserves insertion order and also has Serde support. We could depend on the linked-hash-map git repo, but I don't think crates.io would let us publish with that dependency.

@apasel422
Copy link
Contributor

@dtolnay Right, I'm just wondering why the serde support wasn't implemented in serde itself instead of this crate, then.

@dtolnay
Copy link
Contributor Author

dtolnay commented Apr 20, 2016

It could have been implemented in serde itself. There was precedent for contain-rs accepting serde implementations (contain-rs/vec-map#15). If you prefer, let's revert #48 and I can move it into serde.

@apasel422
Copy link
Contributor

@dtolnay No, that's fine. I just didn't realize that serde was going to be using linked-hash-map as a dependency.

@apasel422 apasel422 merged commit 98f4cb4 into contain-rs:master Apr 20, 2016
@apasel422
Copy link
Contributor

0.0.10 is now published on crates.io.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants