update dependencies to recent versions #51
Conversation
bart0sh
force-pushed
the
PR0012-update-go-mod
branch
2 times, most recently
from
13e9069
to
a369587
Compare
There was a problem hiding this comment.
As @elezar correctly pointed out, we can't update selinux to that version until the related problems (unexplained OpenShift CI kubernetes cluster bootstrapping failures) are solved and this same change is done first in CRI-O.
We could update it, but that would mean that we may run into similar problems when updating the dependency in the crio codebase again. |
bart0sh
force-pushed
the
PR0012-update-go-mod
branch
from
a369587
to
320fda3
Compare
|
As soon as @klihub is happy with this, I'm good to merge. |
|
@klihub I've updated this PR according to your suggestions. Please review again and merge if you're ok with it. |
|
@klihub yep, I've mentioned it in this comment We should probably drop this PR. At least for now. |
Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
bart0sh
force-pushed
the
PR0012-update-go-mod
branch
from
320fda3
to
90cf26a
Compare
| @@ -6,9 +6,9 @@ require ( | |||
| github.com/hashicorp/go-multierror v1.1.1 | |||
| github.com/opencontainers/runc v1.0.3 | |||
| github.com/opencontainers/runtime-spec v1.0.3-0.20210326190908-1c3f411f0417 | |||
| github.com/opencontainers/runtime-tools v0.0.0-20190417131837-cd1349b7c47e | |||
| github.com/opencontainers/runtime-tools v0.9.0 | |||
There was a problem hiding this comment.
This change will break builds. We use AddMultipleProcessEnv() from runtime-tools which is not part of any tagged release, so it requires a SHA1-exact dependency.
There was a problem hiding this comment.
we should probably stop using AddMultipleProcessEnv and upgrade this dependency. The commit we're using is almost 3 years old. Another option is to drop this PR for now. WDYT?
There was a problem hiding this comment.
Wouldn't it be better to suggest tagging a new version of runtime-tools so that when one references that new tag the necessary commit gets pulled in ?
There was a problem hiding this comment.
Of course, if this is a show-stopper then we can rework CDI to use a much older version and later switch back to using AddMultipleProcessEnv, if that ever gets covered by a new tag.
There was a problem hiding this comment.
Not sure it will be ever covered by a new tag. I'll drop this PR as it only upgrades cobra. The rest is not possible to update for one or another reason.
No description provided.