Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting #277

Open
5 tasks
viceice opened this issue Feb 4, 2022 · 0 comments
Open
5 tasks

Linting #277

viceice opened this issue Feb 4, 2022 · 0 comments
Labels
priority-3-normal Default priority, "should be done" but isn't prioritised ahead of others status:ready Ready to start implementation type:refactor Refactoring or improving of existing code

Comments

@viceice
Copy link
Member

viceice commented Feb 4, 2022 •
edited

We should check / add and fix any linting issues on all buildpack repos.

  • use husky, lint-staged, prettier, markdownlint
  • optional linter: shellcheck, eslint (depends on repo)
  • run shellcheck as pull_request_target, so it can send build status

This is also an uber issue for all repos. 🙃

TODO:
@viceice viceice added type:refactor Refactoring or improving of existing code priority-3-normal Default priority, "should be done" but isn't prioritised ahead of others status:ready Ready to start implementation labels Feb 4, 2022
@viceice viceice mentioned this issue May 30, 2023
Merged
viceice added a commit to containerbase/.github that referenced this issue Feb 1, 2024
@viceice
chore: add linting
09229b8 
- containerbase/base#277
viceice added a commit to containerbase/devcontainer that referenced this issue Feb 1, 2024
@viceice
chore: add linting
713c412 
- containerbase/base#277
viceice added a commit to containerbase/gitpod that referenced this issue Feb 1, 2024
@viceice
chore: add linting
74fddde 
- containerbase/base#277
viceice added a commit to containerbase/erlang-prebuild that referenced this issue Feb 1, 2024
@viceice
chore: add linting
cb06913 
- containerbase/base#277
viceice added a commit to containerbase/flutter-prebuild that referenced this issue Feb 1, 2024
@viceice
chore: add linting
f7dc510 
- containerbase/base#277
viceice added a commit to containerbase/node that referenced this issue Feb 1, 2024
@viceice
chore: add linting
b190aaf 
- containerbase/base#277
viceice added a commit to containerbase/node-re2-prebuild that referenced this issue Feb 1, 2024
@viceice
chore: add linting
bee9f98 
- containerbase/base#277
viceice added a commit to containerbase/php-prebuild that referenced this issue Feb 1, 2024
@viceice
chore: add linting
81ad6c9 
- containerbase/base#277
viceice added a commit to containerbase/python-prebuild that referenced this issue Feb 1, 2024
@viceice
chore: add linting
96e9f10 
- containerbase/base#277
viceice added a commit to containerbase/ruby-prebuild that referenced this issue Feb 1, 2024
@viceice
chore: add linting
f09eb69 
- containerbase/base#277
viceice added a commit to containerbase/sidecar that referenced this issue Feb 1, 2024
@viceice
chore: add linting
81377a2 
- containerbase/base#277
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority-3-normal Default priority, "should be done" but isn't prioritised ahead of others status:ready Ready to start implementation type:refactor Refactoring or improving of existing code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@viceice