Added ebps support(based on runc implementation) #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Nov 13, 2019
AkihiroSuda
reviewed
Nov 13, 2019
AkihiroSuda
reviewed
Nov 13, 2019
14 tasks
|
@AkihiroSuda Do we need allowed devices list here? |
|
The current eBPF code already supports allowing specific devices |
Codecov Report
@@ Coverage Diff @@
## master #116 +/- ##
=========================================
+ Coverage 35.46% 36.56% +1.1%
=========================================
Files 32 34 +2
Lines 2154 2297 +143
=========================================
+ Hits 764 840 +76
- Misses 1262 1324 +62
- Partials 128 133 +5
Continue to review full report at Codecov.
|
AkihiroSuda
reviewed
Nov 14, 2019
|
I'm still wondering devices should be under this structure: https://godoc.org/github.com/containerd/cgroups/v2#Resources |
|
Can you rebase this one as well? |
Zyqsempai
force-pushed
the
104-add-bpf-device
branch
from
383624f
to
1820009
Compare
|
@crosbymichael Done |
|
rebase:) |
Signed-off-by: bpopovschi <zyqsempai@mail.ru>
Signed-off-by: bpopovschi <zyqsempai@mail.ru>
Signed-off-by: bpopovschi <zyqsempai@mail.ru>
Signed-off-by: bpopovschi <zyqsempai@mail.ru>
Signed-off-by: bpopovschi <zyqsempai@mail.ru>
Zyqsempai
force-pushed
the
104-add-bpf-device
branch
from
4df6a7b
to
dea9e11
Compare
|
@crosbymichael Done |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Fixes #104
Added eBPS support(based on @AkihiroSuda implementation for runc)
Signed-off-by: bpopovschi zyqsempai@mail.ru