v1: reduce duplicated code #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code for handling Tasks and Processes, except for "cgroup.procs" vs "tasks", and Tasks being a different type. This patch: - Makes the Task type an alias for Process (as they're identical otherwise) - Adds a `processType` type for the `cgroupProcs` and `cgroupTasks` consts. This type is an alias for "string", and mostly for clarity (indicating it's an 'enum'). - Merges the `cgroup.add()` and `cgroup.addTask()` functions, adding a `pType` argument. - Merges the `cgroup.processes()` and `cgroup.tasks()` functions, adding a `pType` argument. - Merges the `readPids()` and `readTasksPids()` utilities, adding a `pType` argument. - Move locking and validation into `cgroup.add()`. All places using `cgroup.add()` were taking a lock and doing this validation, so looks we can move this code into `cgroup.add()` itself. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
cgroupv1_less_dry
branch
from
361bf27
to
4fe70f3
Compare
sameo
approved these changes
Jul 23, 2021
|
Thanks for reviewing! Perhaps @AkihiroSuda or @fuweid could have a look as well (making sure I didn't do anything silly 😂) |
AkihiroSuda
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marking as draft, because this depends on / is a follow-up to #200(merged)Code for handling Tasks and Processes, except for "cgroup.procs" vs "tasks", and Tasks being a different type.
This patch:
processTypetype for thecgroupProcsandcgroupTasksconsts. This type is an alias for "string", and mostly for clarity (indicating it's an 'enum').cgroup.add()andcgroup.addTask()functions, adding apTypeargument.cgroup.processes()andcgroup.tasks()functions, adding apTypeargument.readPids()andreadTasksPids()utilities, adding apTypeargument.cgroup.add(). All places usingcgroup.add()were taking a lock and doing this validation, so looks we can move this code intocgroup.add()itself.