Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[do not merge] containerd/console is broken with current golang.org/x/sys #39

Closed
wants to merge 2 commits into from

Conversation

thaJeztah
Copy link
Member

As mentioned in docker/buildx#389

Needed to downgrade sys/unix with replace rule because the new one (that cli requires through moby/term) does not build with moby/moby and containerd/console. golang/sys@6fcdbc0 Moby isn't big issue as could be upgraded/removed but containerd package looks like a chunk of work (especially because on first look package itself does not seem to be implemented correctly)

opening this to discuss (not sure what the right fix/change is yet)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

CI doesn't run on macOS, but this is the compile failure;

# github.com/containerd/console
./tc_darwin.go:33:31: undefined: unix.SYS_IOCTL

if _, _, err := unix.Syscall(unix.SYS_IOCTL, fd, flag, data); err != 0 {

@thaJeztah
Copy link
Member Author

This probably needs similar changes as were made in moby/term#16 @tklauser ?

@tklauser
Copy link
Contributor

This probably needs similar changes as were made in moby/term#16 @tklauser ?

Yes, looks like it. I've sent #40 with a fix.

@thaJeztah
Copy link
Member Author

let me close this one, now that #40 is up

@thaJeztah thaJeztah closed this Sep 16, 2020
@thaJeztah thaJeztah deleted the update_x_sys branch September 16, 2020 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants