New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor: update buildkit with typed errors support #389
Conversation
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Needed to downgrade sys/unix with replace rule because the new one (that cli requires through moby/term) does not build with moby/moby and containerd/console. golang/sys@6fcdbc0 Moby isn't big issue as could be upgraded/removed but containerd package looks like a chunk of work (especially because on first look package itself does not seem to be implemented correctly). FYI @thaJeztah |
You mean the containerd/console package isn't implemented correctly, or golang/x/sys ? |
@thaJeztah containerd/console |
containerd and moby packages do not build in darwin anymore golang/sys@6fcdbc0 Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
ed9eb75
to
3c94621
Compare
@tonistiigi thanks! Opened containerd/console#39 for discussing |
containerd/console#40 was opened to fix the build on macOS |
@thaJeztah Thanks. Still would like to get this merged as is. Updates should be first vendored into buildkit and takes time when they reach here. |
Ah, sorry, yes of course; just commented to update status on that issue 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com