Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: update buildkit with typed errors support #389

Merged
merged 2 commits into from Sep 17, 2020

Conversation

tonistiigi
Copy link
Member

Signed-off-by: Tonis Tiigi tonistiigi@gmail.com

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi
Copy link
Member Author

Needed to downgrade sys/unix with replace rule because the new one (that cli requires through moby/term) does not build with moby/moby and containerd/console. golang/sys@6fcdbc0 Moby isn't big issue as could be upgraded/removed but containerd package looks like a chunk of work (especially because on first look package itself does not seem to be implemented correctly). FYI @thaJeztah

@thaJeztah
Copy link
Member

especially because on first look package itself does not seem to be implemented correctly

You mean the containerd/console package isn't implemented correctly, or golang/x/sys ?

go.mod Show resolved Hide resolved
@tonistiigi
Copy link
Member Author

@thaJeztah containerd/console

containerd and moby packages do not build in darwin anymore

golang/sys@6fcdbc0

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@thaJeztah
Copy link
Member

@tonistiigi thanks! Opened containerd/console#39 for discussing

@thaJeztah
Copy link
Member

containerd/console#40 was opened to fix the build on macOS

@tonistiigi
Copy link
Member Author

tonistiigi commented Sep 16, 2020

@thaJeztah Thanks. Still would like to get this merged as is. Updates should be first vendored into buildkit and takes time when they reach here.

@thaJeztah
Copy link
Member

Ah, sorry, yes of course; just commented to update status on that issue 😅

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 92fb995 into docker:master Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants