-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #3536 from darfux/ignore_closed_fifo_error_under_m…
…ulti_cntr Ignore fifo error when using v2 multi-container shim
- Loading branch information
Showing
5 changed files
with
119 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
// +build linux | ||
|
||
/* | ||
Copyright The containerd Authors. | ||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
http://www.apache.org/licenses/LICENSE-2.0 | ||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package v2 | ||
|
||
import ( | ||
"context" | ||
"testing" | ||
|
||
"github.com/containerd/fifo" | ||
) | ||
|
||
func TestCheckCopyShimLogError(t *testing.T) { | ||
ctx, cancel := context.WithCancel(context.Background()) | ||
|
||
if err := checkCopyShimLogError(ctx, fifo.ErrReadClosed); err != fifo.ErrReadClosed { | ||
t.Fatalf("should return the actual error before context is done, but %v", err) | ||
} | ||
if err := checkCopyShimLogError(ctx, nil); err != nil { | ||
t.Fatalf("should return the actual error before context is done, but %v", err) | ||
} | ||
|
||
cancel() | ||
|
||
if err := checkCopyShimLogError(ctx, fifo.ErrReadClosed); err != nil { | ||
t.Fatalf("should return nil when error is ErrReadClosed after context is done, but %v", err) | ||
} | ||
if err := checkCopyShimLogError(ctx, nil); err != nil { | ||
t.Fatalf("should return the actual error after context is done, but %v", err) | ||
} | ||
if err := checkCopyShimLogError(ctx, fifo.ErrRdFrmWRONLY); err != fifo.ErrRdFrmWRONLY { | ||
t.Fatalf("should return the actual error after context is done, but %v", err) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
/* | ||
Copyright The containerd Authors. | ||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
http://www.apache.org/licenses/LICENSE-2.0 | ||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package v2 | ||
|
||
import ( | ||
"context" | ||
"os" | ||
"testing" | ||
|
||
"github.com/pkg/errors" | ||
) | ||
|
||
func TestCheckCopyShimLogError(t *testing.T) { | ||
ctx, cancel := context.WithCancel(context.Background()) | ||
defer cancel() | ||
testError := errors.New("test error") | ||
|
||
if err := checkCopyShimLogError(ctx, nil); err != nil { | ||
t.Fatalf("should return the actual error except ErrNotExist, but %v", err) | ||
} | ||
if err := checkCopyShimLogError(ctx, testError); err != testError { | ||
t.Fatalf("should return the actual error except ErrNotExist, but %v", err) | ||
} | ||
if err := checkCopyShimLogError(ctx, os.ErrNotExist); err != nil { | ||
t.Fatalf("should return nil for ErrNotExist, but %v", err) | ||
} | ||
} |