Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Move containerd.IO code as independent containerd repo #1578

Closed
kunalkushwaha opened this issue Oct 2, 2017 · 3 comments
Closed

Comments

@kunalkushwaha
Copy link
Contributor

By containerd.IO I mean io.go, io_unix.go & io_windows.go.

Implementation of IO interface for containerd is completely independent of containerd code, So it can be easily move to independent repo and shall be helpful in reusing code with including whole containerd repo.

@crosbymichael
Copy link
Member

I'm not sure the code is meaningful enough outside of the context of containerd to warrant a separate repo. It would have to be used by multiple projects before we did something like this I think.

Could you explain more why you think this code should be separate?

@kunalkushwaha
Copy link
Contributor Author

Could you explain more why you think this code should be separate?

I am writing one testing tool which can runs same test cases on multiple container runtime. Am thinking to resue this code for other runtimes like cri-o.

I think, I concluded too early for reusing this code. Will implement this first and if required will open this issue.

Sorry for false alarm.
Closing this issue as of now.

@AkihiroSuda
Copy link
Member

see #1782 @kunalkushwaha

mauriciovasquezbernal pushed a commit to kinvolk/containerd that referenced this issue Nov 13, 2020
vendor: github.com/willf/bitset v1.1.11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants