Move io.go into io package #1782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnephin
force-pushed
the
move-io-pkg
branch
2 times, most recently
from
bd297cd
to
bd46b0c
Compare
Codecov Report
@@ Coverage Diff @@
## master #1782 +/- ##
=======================================
Coverage 49.06% 49.06%
=======================================
Files 77 77
Lines 7719 7719
=======================================
Hits 3787 3787
Misses 3289 3289
Partials 643 643
Continue to review full report at Codecov.
|
|
LGTM |
stevvooe
reviewed
Nov 17, 2017
io/io.go
Outdated
| @@ -1,4 +1,4 @@ | |||
| package containerd | |||
| package io | |||
There was a problem hiding this comment.
This package name is problematic is that it overlaps with one of the more common packages, io, that is commonly used in conjunction with this package. The only better, minimal name I can come up with is cio, which would be short for "Container IO".
|
LGTM after changing the name to |
stevvooe
approved these changes
Nov 17, 2017
AkihiroSuda
reviewed
Nov 17, 2017
task.go
Outdated
| @@ -5,7 +5,7 @@ import ( | |||
| "context" | |||
| "encoding/json" | |||
| "fmt" | |||
| "io" | |||
| goio "io" | |||
container.go
Outdated
| // Spec returns the OCI runtime specification | ||
| Spec(context.Context) (*specs.Spec, error) | ||
| // Task returns the current task for the container | ||
| // | ||
| // If IOAttach options are passed the client will reattach to the IO for the running | ||
| // If io.Attach options are passed the client will reattach to the IO for the running |
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
|
Thanks, fixed both of those issues |
AkihiroSuda
approved these changes
Nov 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1756
Move
io*.gofrom the root package into aniopackage so the logic can be tested separate from integration tests.If this looks good I can write a godoc string for the package and couple unit tests.