Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import uncompressd file support for XZ BZip2 #10260

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jokemanfire
Copy link

Signed-off-by: jokemanfire <hu.dingyang@zte.com.cn>>
Signed-off-by: jokemanfire <981376433@qq.com>
@k8s-ci-robot
Copy link

Hi @jokemanfire. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@samuelkarp
Copy link
Member

Do you have specific use cases for XZ and bzip2? Same as discussed before (#10241 (comment)), I'd prefer to avoid new dependencies (compress/bzip2 and the xz CLI) unless we have specific needs for them.

(Note that XZ was the subject of a recent backdoor, so I would encourage the use of alternative compression libraries and algorithms as opposed to xz and lzma.)

@samuelkarp samuelkarp added the status/needs-discussion Needs discussion and decision from maintainers label May 24, 2024
@jokemanfire
Copy link
Author

jokemanfire commented May 25, 2024

I think this is just a user-friendly issue, I pursuit of smaller image packages sometimes. Add more type compressed file type if more convenient for me , that I can choose the compressd type in different scene . Also, prepare for a higher compression ratio image pull.
In my opinion, and I think Decompress should let containerd do but not the cri tool, This will make the supported encoding files uniform, and many other CRI tools do not require additional code. As my add code core/images/archive/importer.go.
This is just my idea.

In example :
xz is the smallest type when I wrap it. I just want to use it in import. such like ctr i import busybox.tar.bz2.....
2.0M 5月 24 21:57 busybox.tar.bz2
2.1M 5月 25 08:28 busybox.tar.gz
1.7M 5月 17 20:26 busybox.tar.xz
Users can manually decompress before import it , but I find moby support it ,it will be more convenient.
XZ backdoor such like didn't introduce to Linux distribution version. And use xz cli , giving the choice to the operating system , But we can carefully consider it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test size/M status/needs-discussion Needs discussion and decision from maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants