Do not touch grpc logger from within the packages #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlaventure
force-pushed
the
dont-touch-grpclog-in-client
branch
from
640fcb1
to
197e85e
Compare
Libraries should not make process wide changes unless requested to. Signed-off-by: Kenfe-Mickael Laventure <mickael.laventure@gmail.com>
mlaventure
force-pushed
the
dont-touch-grpclog-in-client
branch
from
197e85e
to
16f6e09
Compare
Codecov Report
@@ Coverage Diff @@
## master #1288 +/- ##
==========================================
- Coverage 23.45% 23.38% -0.08%
==========================================
Files 40 40
Lines 4574 4575 +1
==========================================
- Hits 1073 1070 -3
- Misses 3299 3303 +4
Partials 202 202
Continue to review full report at Codecov.
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Libraries should not make process wide changes unless requested to.
Signed-off-by: Kenfe-Mickael Laventure mickael.laventure@gmail.com