Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Events client method #1423

Merged
merged 1 commit into from
Aug 25, 2017
Merged

Add Events client method #1423

merged 1 commit into from
Aug 25, 2017

Conversation

crosbymichael
Copy link
Member

Fixes #1381

Signed-off-by: Michael Crosby crosbymichael@gmail.com

Fixes containerd#1381

Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #1423 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1423   +/-   ##
======================================
  Coverage    40.8%   40.8%           
======================================
  Files          23      23           
  Lines        2924    2924           
======================================
  Hits         1193    1193           
  Misses       1453    1453           
  Partials      278     278

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f052817...421c607. Read the comment docs.

Copy link
Contributor

@mlaventure mlaventure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Should we add predefined filters? (e.g. TasksEvent, ContainerEvents ?)

@crosbymichael
Copy link
Member Author

@mlaventure you can if you want ;)

@dmcgowan
Copy link
Member

LGTM

@dmcgowan dmcgowan merged commit 1a77db1 into containerd:master Aug 25, 2017
mauriciovasquezbernal pushed a commit to kinvolk/containerd that referenced this pull request Nov 13, 2020
…newly-tagged-repos

Add version numbers for newly tagged repos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants