archive: remove umask, replace with explicit chmod after create #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call chmod on all open files and created directories to ensure permission is set as expected without changing umask. Fixes containerd#1608 Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Codecov Report
@@ Coverage Diff @@
## master #1629 +/- ##
=========================================
- Coverage 48.87% 48.67% -0.2%
=========================================
Files 27 27
Lines 4074 4074
=========================================
- Hits 1991 1983 -8
- Misses 1668 1672 +4
- Partials 415 419 +4
Continue to review full report at Codecov.
|
|
LGTM |
1 similar comment
|
LGTM |
mlaventure
reviewed
Oct 12, 2017
| } | ||
| // Only final created directory gets explicit permission |
There was a problem hiding this comment.
This comment only makes sense if we were using os.MkdirAll, doesn't it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call chmod on all open files and created directories to ensure permission is set as expected without changing umask.
Fixes #1608