Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output unmount error when unmount fail in diff.Apply #1877

Merged
merged 1 commit into from
Dec 5, 2017

Conversation

yanxuean
Copy link
Member

@yanxuean yanxuean commented Dec 5, 2017

Signed-off-by: yason yan.xuean@zte.com.cn

When unmount fail we should output unmount err and return error.

Signed-off-by: yason <yan.xuean@zte.com.cn>
@dmcgowan dmcgowan added this to the 1.0.0 milestone Dec 5, 2017
@dmcgowan
Copy link
Member

dmcgowan commented Dec 5, 2017

LGTM

@codecov-io
Copy link

Codecov Report

Merging #1877 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1877   +/-   ##
=======================================
  Coverage   48.87%   48.87%           
=======================================
  Files          86       86           
  Lines        8332     8332           
=======================================
  Hits         4072     4072           
  Misses       3586     3586           
  Partials      674      674
Flag Coverage Δ
#linux 52.34% <ø> (ø) ⬆️
#windows 44.1% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b77fa49...147d498. Read the comment docs.

@crosbymichael
Copy link
Member

LGTM

@crosbymichael crosbymichael merged commit a9caf9b into containerd:master Dec 5, 2017
@yanxuean yanxuean deleted the add-unmount-fail-error branch December 5, 2017 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants