-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix website rendering via gh-pages #1955
Conversation
Looks like a possible whitespace issue with the patch:
|
Looks like line ending issue
|
docs/_includes/header.html
Outdated
<link rel="icon" type="image/png" href="images/favicon-16x16.png" sizes="16x16"> | ||
<link href="style/css/flexboxgrid.css" type="text/css" rel="stylesheet" media="screen,projection"/> | ||
<link href="style/css/main.css" type="text/css" rel="stylesheet" media="screen,projection"/> | ||
<link href="style/css/tomorrow-night.css" type="text/css" rel="stylesheet" media="screen,projection"/><link href="https://fonts.googleapis.com/css?family=Lato:300,400|Raleway:400,700i,800" rel="stylesheet"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a missing line break here?
Signed-off-by: Chris Aniszczyk <caniszczyk@gmail.com> Signed-off-by: Stephen J Day <stephen.day@docker.com>
I just modified the commit to fix the line endings. These were already there. |
Codecov Report
@@ Coverage Diff @@
## master #1955 +/- ##
==========================================
+ Coverage 45.7% 46.24% +0.53%
==========================================
Files 94 94
Lines 9308 9377 +69
==========================================
+ Hits 4254 4336 +82
+ Misses 4351 4335 -16
- Partials 703 706 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
Step 1 is to get the CSS/JS to render properly: http://containerd.github.io/containerd/
Signed-off-by: Chris Aniszczyk caniszczyk@gmail.com