Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix website rendering via gh-pages #1955

Merged
merged 1 commit into from
Jan 3, 2018
Merged

Fix website rendering via gh-pages #1955

merged 1 commit into from
Jan 3, 2018

Conversation

caniszczyk
Copy link
Contributor

Step 1 is to get the CSS/JS to render properly: http://containerd.github.io/containerd/

Signed-off-by: Chris Aniszczyk caniszczyk@gmail.com

@estesp
Copy link
Member

estesp commented Jan 3, 2018

Looks like a possible whitespace issue with the patch:

git-validation -q -run DCO,short-subject,dangling-whitespace
 41547d1 - FAIL - has whitespace errors. See `git show --check 41547d1fc573209ed92120ac9262066cf34906ac`.
1 commits to fix
make: *** [dco] Error 1

@dmcgowan
Copy link
Member

dmcgowan commented Jan 3, 2018

Looks like line ending issue

commit 41547d1fc573209ed92120ac9262066cf34906ac (HEAD)
Author: Chris Aniszczyk <caniszczyk@gmail.com>
Date:   Wed Jan 3 12:08:01 2018 -0600

    Fix website rendering via gh-pages
    
    Signed-off-by: Chris Aniszczyk <caniszczyk@gmail.com>

docs/_includes/header.html:7: trailing whitespace.
+    <link rel="icon" type="image/png" href="images/favicon-16x16.png" sizes="16x16">^M
docs/_includes/header.html:8: trailing whitespace.
+    <link href="style/css/flexboxgrid.css" type="text/css" rel="stylesheet" media="screen,projection"/>^M
docs/_includes/header.html:9: trailing whitespace.
+    <link href="style/css/main.css" type="text/css" rel="stylesheet" media="screen,projection"/>^M
docs/_includes/header.html:10: trailing whitespace.
+    <link href="style/css/tomorrow-night.css" type="text/css" rel="stylesheet" media="screen,projection"/><link href="https://fonts.googleapis.com/css?family=Lato:300,400|Raleway:400,700i,800" rel="stylesheet">^M

<link rel="icon" type="image/png" href="images/favicon-16x16.png" sizes="16x16">
<link href="style/css/flexboxgrid.css" type="text/css" rel="stylesheet" media="screen,projection"/>
<link href="style/css/main.css" type="text/css" rel="stylesheet" media="screen,projection"/>
<link href="style/css/tomorrow-night.css" type="text/css" rel="stylesheet" media="screen,projection"/><link href="https://fonts.googleapis.com/css?family=Lato:300,400|Raleway:400,700i,800" rel="stylesheet">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a missing line break here?

Signed-off-by: Chris Aniszczyk <caniszczyk@gmail.com>
Signed-off-by: Stephen J Day <stephen.day@docker.com>
@stevvooe
Copy link
Member

stevvooe commented Jan 3, 2018

I just modified the commit to fix the line endings. These were already there.

@codecov-io
Copy link

codecov-io commented Jan 3, 2018

Codecov Report

Merging #1955 into master will increase coverage by 0.53%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1955      +/-   ##
==========================================
+ Coverage    45.7%   46.24%   +0.53%     
==========================================
  Files          94       94              
  Lines        9308     9377      +69     
==========================================
+ Hits         4254     4336      +82     
+ Misses       4351     4335      -16     
- Partials      703      706       +3
Flag Coverage Δ
#linux 50.94% <ø> (+0.61%) ⬆️
#windows 40.5% <ø> (ø) ⬆️
Impacted Files Coverage Δ
gc/gc.go 70.53% <0%> (+2.67%) ⬆️
gc/scheduler/scheduler.go 72.05% <0%> (+4.09%) ⬆️
metadata/db.go 75.09% <0%> (+8.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a85b1f8...00ad7fe. Read the comment docs.

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Member

LGTM

@crosbymichael crosbymichael merged commit 1a0c7ee into master Jan 3, 2018
@crosbymichael crosbymichael deleted the fix-website branch January 3, 2018 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants