Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CII badge for containerd #1979

Merged
merged 1 commit into from
Jan 9, 2018
Merged

Conversation

crosbymichael
Copy link
Member

Closes #1539

Signed-off-by: Michael Crosby crosbymichael@gmail.com

Closes containerd#1539

Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
@crosbymichael crosbymichael changed the title Add CCI badge for containerd Add CII badge for containerd Jan 9, 2018
@codecov-io
Copy link

Codecov Report

Merging #1979 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1979   +/-   ##
======================================
  Coverage    45.7%   45.7%           
======================================
  Files          94      94           
  Lines        9307    9307           
======================================
  Hits         4254    4254           
  Misses       4350    4350           
  Partials      703     703
Flag Coverage Δ
#linux 50.33% <ø> (ø) ⬆️
#windows 40.49% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b509e78...f6f0e25. Read the comment docs.

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnephin
Copy link
Contributor

dnephin commented Jan 9, 2018

Looking at https://bestpractices.coreinfrastructure.org/projects/1271 It seems like "An open and reliable container runtime" should be replaced with containerd, no?

@crosbymichael
Copy link
Member Author

@dnephin fixed, thanks

Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mlaventure mlaventure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlaventure mlaventure merged commit 2fb85c6 into containerd:master Jan 9, 2018
@crosbymichael crosbymichael deleted the badge branch January 9, 2018 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants