-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print default plugin config. #2030
Print default plugin config. #2030
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2030 +/- ##
==========================================
- Coverage 50.17% 45.58% -4.59%
==========================================
Files 84 94 +10
Lines 7342 9296 +1954
==========================================
+ Hits 3684 4238 +554
- Misses 2952 4348 +1396
- Partials 706 710 +4
Continue to review full report at Codecov.
|
cmd/containerd/config.go
Outdated
// WriteTo marshals the config to the provided writer | ||
func (c *Config) WriteTo(w io.Writer) (int64, error) { | ||
buf := bytes.NewBuffer(nil) | ||
e := toml.NewEncoder(buf) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why use a buffer here and not just w
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copied from original code. Will remove it then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
95a1cb5
to
50fad7e
Compare
@crosbymichael Addressed comments. |
LGTM |
Signed-off-by: Lantao Liu <lantaol@google.com>
50fad7e
to
3d6fe5a
Compare
Fixed a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #2027.
@containerd/containerd-maintainers Does this make sense to you?
The output:
Signed-off-by: Lantao Liu lantaol@google.com