Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: update go-runc to reduce gc pressure #2059

Merged
merged 1 commit into from
Jan 25, 2018

Conversation

stevvooe
Copy link
Member

Signed-off-by: Stephen J Day stephen.day@docker.com

Signed-off-by: Stephen J Day <stephen.day@docker.com>
@stevvooe stevvooe added this to the 1.0.2 milestone Jan 25, 2018
@codecov-io
Copy link

codecov-io commented Jan 25, 2018

Codecov Report

Merging #2059 into master will decrease coverage by 4.92%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2059      +/-   ##
==========================================
- Coverage   50.35%   45.43%   -4.93%     
==========================================
  Files          84       96      +12     
  Lines        7393     9429    +2036     
==========================================
+ Hits         3723     4284     +561     
- Misses       2964     4435    +1471     
- Partials      706      710       +4
Flag Coverage Δ
#linux 50.35% <ø> (ø) ⬆️
#windows 40.31% <ø> (?)
Impacted Files Coverage Δ
fs/path.go 60.69% <0%> (-12.56%) ⬇️
oci/spec.go 40% <0%> (-10%) ⬇️
snapshots/naive/naive.go 43.89% <0%> (-10%) ⬇️
metadata/snapshot.go 45.95% <0%> (-8.96%) ⬇️
archive/compression/compression.go 43.93% <0%> (-8.9%) ⬇️
remotes/docker/fetcher.go 41.42% <0%> (-7.6%) ⬇️
content/local/writer.go 52.63% <0%> (-7.37%) ⬇️
fs/copy.go 34.83% <0%> (-7.2%) ⬇️
archive/tar.go 43.25% <0%> (-6.9%) ⬇️
metadata/containers.go 47.31% <0%> (-6.4%) ⬇️
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fcc52b...f534a20. Read the comment docs.

@crosbymichael
Copy link
Member

LGTM

@crosbymichael crosbymichael merged commit b268261 into containerd:master Jan 25, 2018
@stevvooe stevvooe deleted the update-go-runc branch January 25, 2018 21:20
estesp referenced this pull request Jan 25, 2018
[release/1.0] vendor: update go-runc to reduce gc pressure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants