CI check for file-header added #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunalkushwaha
force-pushed
the
file-header-ci-check
branch
4 times, most recently
from
74deb33
to
f6d15d6
Compare
|
Thanks for adding this. Looks like a couple of files are missing the header :) |
kunalkushwaha
force-pushed
the
file-header-ci-check
branch
from
f6d15d6
to
3c4a026
Compare
Signed-off-by: Kunal Kushwaha <kushwaha_kunal_v7@lab.ntt.co.jp>
|
Updated missing header of new files. The CI error is due to blank lines at EOF in |
|
You should be able to add that to the ignore var like the vendor scripts are added |
kunalkushwaha
force-pushed
the
file-header-ci-check
branch
4 times, most recently
from
12725bf
to
f040e6a
Compare
file-header check using github.com/kunalkushwaha/ltag Signed-off-by: Kunal Kushwaha <kushwaha_kunal_v7@lab.ntt.co.jp>
|
CI error will be fixed with merge of vbatts/git-validation#34 |
|
@crosbymichael This needs re-tun the travis. vbatts/git-validation#34 is merged, so it will pass the CI test. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file-header check using github.com/kunalkushwaha/ltag
follow-up of #2108
Signed-off-by: Kunal Kushwaha kushwaha_kunal_v7@lab.ntt.co.jp