-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to Go 1.11.0 #2435
Bump to Go 1.11.0 #2435
Conversation
70f6a53
to
eefabd4
Compare
content/testsuite/testsuite.go
Outdated
@@ -367,6 +367,7 @@ func checkLabels(ctx context.Context, t *testing.T, cs content.Store) { | |||
labels := map[string]string{ | |||
"k1": "v1", | |||
"k2": "v2", | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened a ticket upstream for the gofmt
change; golang/go#26228
temporarily cherry-picked #2420 to fix compilation on 1.11 |
Okay, we're getting closer; 3 out of four pass (on Linux); There's a panic on Go 1.11beta1 with
Panic is done here; containerd/cmd/containerd-stress/main.go Lines 59 to 62 in c3971b1
Originating from containerd/cmd/containerd-stress/rlimit_unix.go Lines 25 to 40 in c3971b1
|
|
Just checked, no changes to those syscalls. May be a regression in CGO, may want to print the value returned by |
Failure on Windows; looks like there were some more format errors;
|
Pushed a commit here, and as a separate PR; #2487 |
Codecov Report
@@ Coverage Diff @@
## master #2435 +/- ##
==========================================
+ Coverage 43.74% 44.76% +1.01%
==========================================
Files 100 93 -7
Lines 10728 9555 -1173
==========================================
- Hits 4693 4277 -416
+ Misses 5305 4585 -720
+ Partials 730 693 -37
Continue to review full report at Codecov.
|
Yay! All green now! Let me rebase to get rid of the extra commit |
Why would we bump to a beta version? |
@crosbymichael sorry, probably should've kept the |
e576186
to
5e906a2
Compare
5e906a2
to
eaea620
Compare
.travis.yml
Outdated
@@ -7,7 +7,7 @@ services: | |||
language: go | |||
|
|||
go: | |||
- "1.10.x" | |||
- "1.11" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be changed to 1.11.x
once the first patch release for Go 1.11 is released
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update this now? Now that 1.2 is out I think if you change this to 1.11.x we can merge this.
Go 1.11 was released, so this is now no longer "WIP" |
LGTM |
Any reason or risk to changing this before 1.2? My preference would be to leave this open to test but merge after 1.2.0-rc.0. |
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
eaea620
to
07237e3
Compare
@estesp rebased and updated; thanks for the ping 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Already saw some breakage in moby/moby#37358, so lets run it here as well
Changelog: https://tip.golang.org/doc/go1.11