Support specifying host in resolver. #2450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2450 +/- ##
==========================================
+ Coverage 45.01% 45.04% +0.02%
==========================================
Files 92 92
Lines 9414 9424 +10
==========================================
+ Hits 4238 4245 +7
- Misses 4493 4496 +3
Partials 683 683
Continue to review full report at Codecov.
|
dmcgowan
reviewed
Jul 9, 2018
remotes/docker/resolver.go
Outdated
| @@ -65,6 +66,9 @@ type ResolverOptions struct { | |||
| // is interpretted as a long lived token. | |||
| Credentials func(string) (string, string, error) | |||
|
|
|||
| // Host is the hostname of the registry. | |||
| Host string | |||
There was a problem hiding this comment.
Can we provide this as a function? A resolver is intended to handle multiple namespaces/hosts
We could have the docker.io handling as a default function here
Random-Liu
force-pushed
the
support-host-in-resolver
branch
from
908e349
to
684dc87
Compare
Signed-off-by: Lantao Liu <lantaol@google.com>
Random-Liu
force-pushed
the
support-host-in-resolver
branch
from
684dc87
to
c8a8a49
Compare
AkihiroSuda
approved these changes
Jul 10, 2018
abhi
approved these changes
Jul 10, 2018
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very useful to implement high level policies like registry mirror. See containerd/cri#838
Signed-off-by: Lantao Liu lantaol@google.com