Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge WithResources for Linux/Windows TaskOpts #2599

Merged
merged 1 commit into from
Aug 31, 2018

Conversation

jterry75
Copy link
Contributor

Signed-off-by: Justin Terry (VM) juterry@microsoft.com

task_opts.go Outdated Show resolved Hide resolved
Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>
@codecov-io
Copy link

codecov-io commented Aug 30, 2018

Codecov Report

Merging #2599 into master will increase coverage by 3.44%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2599      +/-   ##
==========================================
+ Coverage   44.03%   47.48%   +3.44%     
==========================================
  Files          94       87       -7     
  Lines       10235     8150    -2085     
==========================================
- Hits         4507     3870     -637     
+ Misses       5008     3557    -1451     
- Partials      720      723       +3
Flag Coverage Δ
#linux 47.48% <ø> (ø) ⬆️
#windows ?
Impacted Files Coverage Δ
oci/spec.go 82.09% <0%> (-11.42%) ⬇️
remotes/docker/auth.go 63.82% <0%> (-3.97%) ⬇️
remotes/docker/status.go 21.42% <0%> (-3.58%) ⬇️
platforms/cpuinfo.go 4.65% <0%> (-1.01%) ⬇️
oci/spec_opts.go 23.07% <0%> (-0.72%) ⬇️
log/context.go 36.84% <0%> (-0.66%) ⬇️
namespaces/context.go 55% <0%> (-0.56%) ⬇️
errdefs/grpc.go 74.6% <0%> (-0.4%) ⬇️
remotes/docker/pusher.go 0% <0%> (ø) ⬆️
content/local/locks.go 100% <0%> (ø) ⬆️
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 777cc50...c48f8de. Read the comment docs.

@crosbymichael
Copy link
Member

LGTM

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 399dba5 into containerd:master Aug 31, 2018
@jterry75 jterry75 deleted the windows_task_opt branch August 31, 2018 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants