Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo: fix misspells in comments of containers/contaienrs.go #2681

Merged
merged 1 commit into from
Sep 25, 2018

Conversation

starnop
Copy link
Contributor

@starnop starnop commented Sep 25, 2018

Signed-off-by: Starnop starnop@163.com

fix misspells in comments of containers/contaienrs.go including:
s/nameapace/namespace
s/contaienr/container

Signed-off-by: Starnop <starnop@163.com>
@codecov-io
Copy link

Codecov Report

Merging #2681 into master will decrease coverage by 3.73%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2681      +/-   ##
=========================================
- Coverage   48.74%     45%   -3.74%     
=========================================
  Files          85      92       +7     
  Lines        8054   10114    +2060     
=========================================
+ Hits         3926    4552     +626     
- Misses       3408    4842    +1434     
  Partials      720     720
Flag Coverage Δ
#linux 48.74% <ø> (ø) ⬆️
#windows 41.76% <ø> (?)
Impacted Files Coverage Δ
snapshots/native/native.go 43.3% <0%> (-10%) ⬇️
metadata/snapshot.go 45.8% <0%> (-8.96%) ⬇️
archive/tar.go 43.13% <0%> (-6.87%) ⬇️
metadata/containers.go 47.97% <0%> (-6.62%) ⬇️
content/local/writer.go 56.25% <0%> (-6.42%) ⬇️
content/local/store.go 48.76% <0%> (-4.77%) ⬇️
archive/tar_opts.go 28.57% <0%> (-4.77%) ⬇️
metadata/images.go 58.46% <0%> (-4.7%) ⬇️
metadata/buckets.go 56.33% <0%> (-4.6%) ⬇️
metadata/adaptors.go 41.46% <0%> (-4.49%) ⬇️
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87d1118...a121b2f. Read the comment docs.

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ehazlett
Copy link
Member

LGTM

@crosbymichael crosbymichael merged commit 3bc4ba2 into containerd:master Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants