-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare 1.1.5 release notes #2787
Prepare 1.1.5 release notes #2787
Conversation
Codecov Report
@@ Coverage Diff @@
## release/1.1 #2787 +/- ##
============================================
Coverage 48.99% 48.99%
============================================
Files 85 85
Lines 7603 7603
============================================
Hits 3725 3725
Misses 3203 3203
Partials 675 675
Continue to review full report at Codecov.
|
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; but minor comment about how to describe the modprobe overlay
problem in case we want to expand it.
releases/v1.1.5.toml
Outdated
* Fix a bug that containerd-shim may hang when many exec processes simultaneously | ||
run in a container. | ||
* Ignore `modprobe overlay` errors in the systemd unit file. This fixes containerd | ||
start failures in some containerized environment, e.g. LXC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really minor, but we could mention this affected not just LXC but kernels with overlay built-in, and also use cases where overlay isn't being used (and maybe not available on a specialized host OS). Any of these situations would have a modprobe
non-zero return code, causing startup to fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Feel free to correct any grammar error, :p
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
93fe969
to
3808808
Compare
heads up; I opened #2802, which should probably be added if that gets merged before 1.1.5 is released |
ACK. I'll update the release note correspondingly. |
Merged one more fix in, update and do the release today? |
SG, I'll send the cherrypick, and we can let the test run for 2~3 hours, and then cut the release? |
Here is the cherrypick #2818 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; thanks for handling the 1.1.5 release @Random-Liu!
Signed-off-by: Lantao Liu <lantaol@google.com>
3808808
to
32d08d0
Compare
Updated the release note with "Update runc". |
LGTM |
Feel free to comment if the anything is missing or there is any mistake.
Signed-off-by: Lantao Liu lantaol@google.com