Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 1.1.5 release notes #2787

Merged
merged 1 commit into from
Nov 21, 2018

Conversation

Random-Liu
Copy link
Member

Feel free to comment if the anything is missing or there is any mistake.

Signed-off-by: Lantao Liu lantaol@google.com

@codecov-io
Copy link

codecov-io commented Nov 13, 2018

Codecov Report

Merging #2787 into release/1.1 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/1.1    #2787   +/-   ##
============================================
  Coverage        48.99%   48.99%           
============================================
  Files               85       85           
  Lines             7603     7603           
============================================
  Hits              3725     3725           
  Misses            3203     3203           
  Partials           675      675
Flag Coverage Δ
#linux 48.99% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cbe42a...32d08d0. Read the comment docs.

@crosbymichael
Copy link
Member

LGTM

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; but minor comment about how to describe the modprobe overlay problem in case we want to expand it.

* Fix a bug that containerd-shim may hang when many exec processes simultaneously
run in a container.
* Ignore `modprobe overlay` errors in the systemd unit file. This fixes containerd
start failures in some containerized environment, e.g. LXC.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really minor, but we could mention this affected not just LXC but kernels with overlay built-in, and also use cases where overlay isn't being used (and maybe not available on a specialized host OS). Any of these situations would have a modprobe non-zero return code, causing startup to fail.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Feel free to correct any grammar error, :p

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Random-Liu Random-Liu force-pushed the prepare-1-1-5-release branch 2 times, most recently from 93fe969 to 3808808 Compare November 14, 2018 18:36
@thaJeztah
Copy link
Member

heads up; I opened #2802, which should probably be added if that gets merged before 1.1.5 is released

@Random-Liu
Copy link
Member Author

heads up; I opened #2802, which should probably be added if that gets merged before 1.1.5 is released

ACK. I'll update the release note correspondingly.

@dmcgowan
Copy link
Member

Merged one more fix in, update and do the release today?

@Random-Liu
Copy link
Member Author

SG, I'll send the cherrypick, and we can let the test run for 2~3 hours, and then cut the release?

@Random-Liu
Copy link
Member Author

Here is the cherrypick #2818

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks for handling the 1.1.5 release @Random-Liu!

Signed-off-by: Lantao Liu <lantaol@google.com>
@Random-Liu
Copy link
Member Author

Updated the release note with "Update runc".

@dmcgowan
Copy link
Member

LGTM

@dmcgowan dmcgowan merged commit 5960cad into containerd:release/1.1 Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants