Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/1.2] Cherry-pick: optimize shim lock in runtime v1 #2795

Merged

Conversation

estesp
Copy link
Member

@estesp estesp commented Nov 16, 2018

apply lock only around process map of shim service, avoid lock affect
other procs operations.

Cherry-pick: #2743

Signed-off-by: Ace-Tang aceapril@126.com
Signed-off-by: Phil Estes estesp@linux.vnet.ibm.com

apply lock only around process map of shim service, avoid lock affect
other procs operations.

Signed-off-by: Ace-Tang <aceapril@126.com>
Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>
@estesp estesp added this to the 1.2.1 milestone Nov 16, 2018
@codecov-io
Copy link

codecov-io commented Nov 16, 2018

Codecov Report

Merging #2795 into release/1.2 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/1.2    #2795   +/-   ##
============================================
  Coverage        43.74%   43.74%           
============================================
  Files              100      100           
  Lines            10728    10728           
============================================
  Hits              4693     4693           
  Misses            5305     5305           
  Partials           730      730
Flag Coverage Δ
#linux 47.41% <ø> (ø) ⬆️
#windows 40.9% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 040e73f...7ef5285. Read the comment docs.

@crosbymichael
Copy link
Member

LGTM

@ehazlett
Copy link
Member

LGTM

@crosbymichael crosbymichael merged commit 39cd863 into containerd:release/1.2 Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants