-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in shim path lookup #2961
Conversation
Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>
@crosbymichael, @ehazlett - Well that was embarrassing. #2960 had a copy paste bug that compiled by accident and updated the wrong path. Here is the correct fix. |
@crosbymichael - What is the build failure here? Its unclear from the logs |
it seems that client failed to connect containerd.
|
It looks like windows CI is having some issues and is not being stable |
Codecov Report
@@ Coverage Diff @@
## master #2961 +/- ##
==========================================
- Coverage 47.62% 44.33% -3.29%
==========================================
Files 92 102 +10
Lines 8517 10907 +2390
==========================================
+ Hits 4056 4836 +780
- Misses 3734 5339 +1605
- Partials 727 732 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Justin Terry (VM) juterry@microsoft.com