-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows: Enable ETW logging #3036
Conversation
Nice! LGTM (fix the build break with the extra |
@jhowardmsft - Do we want to remove the event log logging hook? |
@jterry75 don't think we should remove the event log hook yet. We can register a service to cause these ETW events to show up in event log, and then removing it's a good idea, but we should do that first in case anyone relies on it. |
@kevpar - I agree for Docker but this is new in CD anyways. Should we just effectively 'never add it'? |
@jterry75 We might want to check with Nick first, I think event log -> fluentd might be their plan for logs. |
Signed-off-by: John Howard <jhoward@microsoft.com>
Removed. (Odd that lint didn't flag it on my dev box, but whatevs....) |
Looks like the vendor on linux is broken with this change.
|
@crosbymichael Fixed now. Some Windows-style line endings had crept into go-winio. Updated that repo, cut a new release and updated the vendoring commit again. |
Codecov Report
@@ Coverage Diff @@
## master #3036 +/- ##
=======================================
Coverage 43.87% 43.87%
=======================================
Files 102 102
Lines 10903 10903
=======================================
Hits 4784 4784
Misses 5384 5384
Partials 735 735
Continue to review full report at Codecov.
|
Overall, this looks good. I think we can move the initialization in an |
Signed-off-by: John Howard <jhoward@microsoft.com>
Signed-off-by: John Howard <jhoward@microsoft.com>
@crosbymichael Yes, makes sense. Updated. |
LGTM |
Signed-off-by: John Howard jhoward@microsoft.com
Enables ETW logging on Windows. (https://docs.microsoft.com/en-us/windows/desktop/etw/event-tracing-portal as a starting point for more information)
@kevpar @jterry75 FYI.