Use golang.org/x/net/context for now #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll move to "context" once the grpc, protobuf and protoc-gen-go packages have done so (see grpc/grpc-go#711) This also forced me to manually update tonistiigi/fifo to use the old context path for now. This change ensures we stay compatible with go1.6.x Signed-off-by: Kenfe-Mickael Laventure <mickael.laventure@gmail.com>
runcom
reviewed
Oct 31, 2016
| "io" | ||
| "os" | ||
| "runtime" | ||
| "sync" | ||
| "syscall" | ||
|
|
||
| "github.com/pkg/errors" | ||
| "golang.org/x/net/context" |
There was a problem hiding this comment.
will this work in docker itself?
There was a problem hiding this comment.
docker still uses golang.org/x/net/context almost everywhere except in 3 files, so it should still work (also, this file wouldn't end up being imported into docker by hack/vendor.sh).
I'll give it a try just to be sure though.
Thanks for pointing it out
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll move to "context" once the grpc, protobuf and protoc-gen-go packages have
done so (see grpc/grpc-go#711)
This also forced me to manually update tonistiigi/fifo to use the old
context path for now.
This change ensures we stay compatible with go1.6.x
Signed-off-by: Kenfe-Mickael Laventure mickael.laventure@gmail.com