[release/1.2 backport] bump google.golang.org/grpc v1.23.1 #3995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
full diff: grpc/grpc-go@v1.23.0...v1.23.1 - grpc/grpc-go#3018 server: set and advertise max frame size of 16KB - grpc/grpc-go#3017 grpclb: fix deadlock in grpclb connection cache - Before the fix, if the timer to remove a SubConn fires at the same time NewSubConn cancels the timer, it caused a mutex leak and deadlock. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 885232b) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
oh, looking at the diff, looks like only the second change is relevant (the deadlock is not in the vendored code). |
Codecov Report
@@ Coverage Diff @@
## release/1.2 #3995 +/- ##
===============================================
+ Coverage 44.19% 47.87% +3.67%
===============================================
Files 100 91 -9
Lines 10847 8483 -2364
===============================================
- Hits 4794 4061 -733
+ Misses 5313 3688 -1625
+ Partials 740 734 -6
Continue to review full report at Codecov.
|
|
LGTM (non-binding) Looks like we dont vendor https://github.com/grpc/grpc-go/pull/3017/files#diff-8bb01acc1b713db5076a08e7eabe55a9R176-L182 so this is just about the change in 3018 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #3767
full diff: grpc/grpc-go@v1.23.0...v1.23.1
same time NewSubConn cancels the timer, it caused a mutex leak
and deadlock.