Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.2] Revert #3366 #4024

Closed
wants to merge 1 commit into from
Closed

[1.2] Revert #3366 #4024

wants to merge 1 commit into from

Conversation

ehazlett
Copy link
Member

This reverts #3366 to fix #4023

@AkihiroSuda
Copy link
Member

Do we need this only for 1.2?

@hakman hakman mentioned this pull request Feb 14, 2020
Merged
@zhsj
Copy link
Contributor

zhsj commented Feb 14, 2020

Other branches are fixed by #3857, so I think it's better to backport #3857 to release/1.2.

@thaJeztah
Copy link
Member

Good catch, @zhsj - let me prepare a backport for consideration

@thaJeztah thaJeztah mentioned this pull request Feb 14, 2020
Merged
@thaJeztah
Copy link
Member

opened #4025 as alternative to this one

@ehazlett ehazlett closed this Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ehazlett @AkihiroSuda @zhsj @thaJeztah