Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for func in remotes/docker/handler.go #4135

Merged
merged 1 commit into from
Mar 31, 2020

Conversation

hs0210
Copy link
Contributor

@hs0210 hs0210 commented Mar 31, 2020

Signed-off-by: Hu Shuai hus.fnst@cn.fujitsu.com

Signed-off-by: Hu Shuai <hus.fnst@cn.fujitsu.com>
@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 31, 2020

Build succeeded.

@codecov-io
Copy link

codecov-io commented Mar 31, 2020

Codecov Report

Merging #4135 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4135      +/-   ##
==========================================
+ Coverage   42.40%   42.42%   +0.01%     
==========================================
  Files         130      130              
  Lines       14884    14884              
==========================================
+ Hits         6312     6314       +2     
+ Misses       7653     7651       -2     
  Partials      919      919              
Flag Coverage Δ
#linux 45.74% <ø> (+0.01%) ⬆️
#windows 38.19% <ø> (+0.01%) ⬆️
Impacted Files Coverage Δ
remotes/docker/handler.go 24.71% <0.00%> (+2.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a83927d...c8d9c6f. Read the comment docs.

@crosbymichael
Copy link
Member

LGTM

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit e852da5 into containerd:master Mar 31, 2020
@hs0210 hs0210 deleted the work branch April 1, 2020 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants