Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade containerd/cgroups to b4448137398923af7f4918b8b2ad8249172ca7a6 #4146

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

kzys
Copy link
Member

@kzys kzys commented Apr 3, 2020

I'd like to include my metrics fix (containerd/cgroups#147) and hopefully include the change in 1.3.x branch as well, since this is a bug fix.

full diff: containerd/cgroups@7347743...b444813

Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 3, 2020

Build succeeded.

@codecov-io
Copy link

Codecov Report

Merging #4146 into master will increase coverage by 3.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4146      +/-   ##
==========================================
+ Coverage   42.42%   45.46%   +3.04%     
==========================================
  Files         130      119      -11     
  Lines       14884    12196    -2688     
==========================================
- Hits         6314     5545     -769     
+ Misses       7651     5723    -1928     
- Partials      919      928       +9     
Flag Coverage Δ
#linux 45.46% <ø> (-0.29%) ⬇️
#windows ?
Impacted Files Coverage Δ
remotes/docker/fetcher.go 54.11% <0.00%> (-5.41%) ⬇️
remotes/docker/auth.go 63.82% <0.00%> (-3.97%) ⬇️
remotes/docker/status.go 21.42% <0.00%> (-3.58%) ⬇️
remotes/docker/errdesc.go 28.12% <0.00%> (-2.65%) ⬇️
remotes/docker/errcode.go 47.61% <0.00%> (-1.60%) ⬇️
filters/scanner.go 81.35% <0.00%> (-0.85%) ⬇️
platforms/platforms.go 79.41% <0.00%> (-0.81%) ⬇️
platforms/cpuinfo.go 3.57% <0.00%> (-0.72%) ⬇️
errdefs/grpc.go 77.46% <0.00%> (-0.04%) ⬇️
log/context.go 100.00% <0.00%> (ø)
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e852da5...3261fb5. Read the comment docs.

Copy link
Member

@mxpv mxpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants