Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance logging driver to support windows #4759

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Enhance logging driver to support windows #4759

merged 1 commit into from
Jan 22, 2021

Conversation

anmaxvl
Copy link
Contributor

@anmaxvl anmaxvl commented Nov 20, 2020 •
edited
Loading

Add windows version of the logging driver. Add log-uri parsing to windows ctr.

Signed-off-by: Maksim An maksiman@microsoft.com

@k8s-ci-robot
Copy link

Hi @anmaxvl. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@anmaxvl anmaxvl marked this pull request as ready for review November 20, 2020 09:20
@anmaxvl anmaxvl mentioned this pull request Nov 20, 2020
Merged
2 tasks
@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 20, 2020

Build succeeded.

@anmaxvl
Copy link
Contributor Author

anmaxvl commented Nov 20, 2020

@kevpar @katiewasnothere @dcantah @ambarve fyi

@anmaxvl
Copy link
Contributor Author

anmaxvl commented Nov 30, 2020

can anyone take a look, please? @cpuguy83 ?

kevpar
kevpar requested changes Dec 1, 2020
View reviewed changes
Copy link
Member

@kevpar kevpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments

@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 1, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 2, 2020

Build succeeded.

@anmaxvl
Copy link
Contributor Author

anmaxvl commented Dec 3, 2020

Few comments

how about now?

@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 7, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 8, 2020

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 8, 2020

Build succeeded.

cpuguy83
cpuguy83 approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theopenlab-ci
Copy link

theopenlab-ci bot commented Dec 9, 2020

Build succeeded.

@anmaxvl
Copy link
Contributor Author

anmaxvl commented Dec 10, 2020

@kevpar @crosbymichael, PTAL

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 14, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 20, 2021

Build succeeded.

kevpar
kevpar approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@kevpar kevpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 20, 2021

Build succeeded.

@anmaxvl
Enhance logging driver and ctr tasks to support windows
ddb5e16 
Signed-off-by: Maksim An <maksiman@microsoft.com>
@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 21, 2021

Build succeeded.

dmcgowan
dmcgowan approved these changes Jan 22, 2021
View reviewed changes
Copy link
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit 809635b into containerd:master Jan 22, 2021
@anmaxvl anmaxvl deleted the anmaxvl/windows-logging-driver branch January 22, 2021 08:03
@anmaxvl anmaxvl mentioned this pull request Sep 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@kzys kzys kzys approved these changes

@dmcgowan dmcgowan dmcgowan approved these changes

@kevpar kevpar kevpar approved these changes

@dcantah dcantah dcantah approved these changes

Assignees
No one assigned
Labels
needs-ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@anmaxvl @k8s-ci-robot @kzys @dmcgowan @kevpar @cpuguy83 @dcantah