travis: Add Go 1.8 #537
Merged
travis: Add Go 1.8 #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samuel Karp <skarp@amazon.com>
Codecov Report
@@ Coverage Diff @@
## master #537 +/- ##
=======================================
Coverage 62.12% 62.12%
=======================================
Files 3 3
Lines 404 404
=======================================
Hits 251 251
Misses 93 93
Partials 60 60Continue to review full report at Codecov.
|
|
LGTM |
runcom
reviewed
Feb 20, 2017
| @@ -5,6 +5,7 @@ language: go | |||
|
|
|||
| go: | |||
| - 1.7 | |||
There was a problem hiding this comment.
1.7 means 1.7.0 in Travis - this should actually be 1.7.x and below 1.8.x @estesp @crosbymichael
There was a problem hiding this comment.
indeed till now, this repo has been testing with go1.7.0 (not latest 1.7.5)
There was a problem hiding this comment.
Thanks! I'll open a new PR shortly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.