Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run fuzzers in CI #7052

Merged
merged 1 commit into from
Jun 15, 2022
Merged

Run fuzzers in CI #7052

merged 1 commit into from
Jun 15, 2022

Conversation

AdamKorcz
Copy link
Contributor

This PR adds CIFuzz to Containerds CI. CIFuzz is a service offered by OSS-Fuzz and is recommended for all OSS-Fuzz projects. It will run all fuzzers for 10 minutes in the CI to catch low-hanging bugs and verify that no breaking changes to the fuzzing suite are introduced.

The time each fuzzer should run can be adjusted.
Only fuzzers that cover code that is affected by changes in PRs will run.

The CIFuzz documentation can be found here: https://google.github.io/oss-fuzz/getting-started/continuous-integration/

@k8s-ci-robot
Copy link

Hi @AdamKorcz. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@kzys kzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

It shouldn't fail though.

.github/workflows/cifuzz.yml Outdated Show resolved Hide resolved
Signed-off-by: AdamKorcz <Adam@adalogics.com>
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kzys kzys merged commit 04874d5 into containerd:main Jun 15, 2022
kzys added a commit to kzys/containerd that referenced this pull request Jun 15, 2022
In addition to oss-fuzz's CIFuzz (see containerd#7052), this commit adds a small
shell script that run all fuzzing tests with go test -fuzz.

While running for 30 seconds would be too short to acutally find issues,
we want to make sure that these fuzzing tests are not fundamentally
broken.

Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys added a commit to kzys/containerd that referenced this pull request Jun 15, 2022
In addition to oss-fuzz's CIFuzz (see containerd#7052), this commit adds a small
shell script that run all fuzzing tests with go test -fuzz.

While running for 30 seconds would be too short to acutally find issues,
we want to make sure that these fuzzing tests are not fundamentally
broken.

Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys added a commit to kzys/containerd that referenced this pull request Jun 15, 2022
In addition to oss-fuzz's CIFuzz (see containerd#7052), this commit adds a small
shell script that run all fuzzing tests with go test -fuzz.

While running for 30 seconds would be too short to acutally find issues,
we want to make sure that these fuzzing tests are not fundamentally
broken.

Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
@mxpv mxpv mentioned this pull request Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants