cri: make swapping disabled with memory limit #7783
Conversation
|
Hi @mqasimsarfraz. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
mqasimsarfraz
force-pushed
the
qasim/cri-disable-swap
branch
from
cc5d6a6
to
8a1c5e7
Compare
mqasimsarfraz
force-pushed
the
qasim/cri-disable-swap
branch
from
8a1c5e7
to
c68ffd1
Compare
OCI runtime spec defines memory.swap as 'limit of memory+Swap usage' so setting them to equal should disable the swap. Also, this change should make containerd behaviour same as other runtimes e.g 'cri-dockerd/dockershim' and won't be impacted when user turn on 'NodeSwap' (kubernetes/enhancements#2400) feature. Signed-off-by: Qasim Sarfraz <qasimsarfraz@microsoft.com>
mqasimsarfraz
force-pushed
the
qasim/cri-disable-swap
branch
from
c68ffd1
to
69975b9
Compare
|
/test pull-containerd-sandboxed-node-e2e |
fuweid
added
the
cherry-pick/1.6.x
fuweid
added
cherry-picked/1.6.x
OCI runtime spec defines memory.swap as 'limit of memory+Swap usage' so setting them to equal should disable the swap (limits for cgroup v1). Also, this change should make containerd behaviour same as other runtimes e.g cri-dockerd/dockershim and won't be impacted when user turn on 'NodeSwap' (kubernetes/enhancements#2400) feature.
We hit this issue in environment where swap was enabled and
containerdcreated container wasn't getting killed withOOMunlike other runtimes.Fixes #7749
Signed-off-by: Qasim Sarfraz qasimsarfraz@microsoft.com