sandbox: modify sandbox client #9883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @abel-von. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This was referenced Feb 27, 2024
which is not used and for some sandbox implementation, we may not get the pid of a sandbox. Signed-off-by: Abel Feng <fshb1988@gmail.com>
abel-von
force-pushed
the
modify-sandbox-client
branch
from
b38c200
to
6781371
Compare
mxpv
approved these changes
May 7, 2024
fuweid
approved these changes
May 7, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PID of sandbox client is not used by anywhere, and I think for some kind of sandbox, it may not have a pid. so I removed PID method in this PR, and for sandboxed Task we can get the connection of Task API directly from the endpoint of the sandbox, so I add a Endpoint call there. And so the Metadata method, which is required to get all information of the sandbox.
Needs to rebase after #9736