-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sandbox: update sandbox resource before/after task creation/deletion #9904
base: main
Are you sure you want to change the base?
Conversation
Hi @abel-von. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
b8115cd
to
4dc8e31
Compare
Signed-off-by: Abel Feng <fshb1988@gmail.com>
there are two kinds of task, shimTask and sandboxedTask, shimTask is the legacy implementation and compatible with the podsandbox, the sandboxedTask is the task running in the sandbox created by sandbox sontroller v2 Signed-off-by: Abel Feng <fshb1988@gmail.com>
Signed-off-by: Abel Feng <fshb1988@gmail.com>
Signed-off-by: Abel Feng <fshb1988@gmail.com>
4dc8e31
to
7fa479a
Compare
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
For sandboxed Task, we call the task api directly into the sandbox. For some kind of sandbox, we may have to update the resources of the sandbox before/after task creation or deletion, and it has to be done outside the sandbox, so we rely on the sandbox controller to update the resources of the sandbox.