Add unit testing #14
Merged
Add unit testing #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating digest from bytes can no longer throw an error in the latest digest package version. Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
Absolute symlinks were using the original path instead of the target path. Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
| uidStr := strconv.Itoa(r.uid) | ||
| gidStr := strconv.Itoa(r.uid) | ||
| switch r.kind { | ||
| case rfile: |
There was a problem hiding this comment.
So, it would be nice to get rid of these test types. I actually made them before the advent of the default package schema. I think this use case could be filled in with a declarative resource struct, coupled with a method that will select the correct wrapping type:
r, err := Declare(Resource{
Kind: RegularFile,
Path: "/foo",
})And for inline declarations for making tests:
[]Resource{
MustDeclare(Resource{
Kind: RegularFile,
Path: "/foo",
}),
}There was a problem hiding this comment.
Created issue #15 to track this
|
LGTM My comment is really to inform refactoring of test code. Accepting this as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the unit testing to check the resources from the manifest.
Add support for Linux device info (needed for testing but support for device numbers may be dropped altogether in the future).
Fix bug with absolute symlinks getting wrong target in created Resource.