This repository has been archived by the owner on Mar 9, 2022. It is now read-only.
Add container Exec support. #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lantao Liu <lantaol@google.com>
mikebrow
reviewed
Aug 7, 2017
| @@ -100,16 +149,11 @@ func (c *criContainerdService) ExecSync(ctx context.Context, r *runtime.ExecSync | |||
| if err != nil { | |||
| return nil, fmt.Errorf("failed to wait for exec in container %q to finish: %v", id, err) | |||
There was a problem hiding this comment.
always throw out the exit code if there is an error? unknownExitCode?
There was a problem hiding this comment.
Maybe we should let waitContainerExec also return pointer, so that we don't need the unknownExitStatus for now.
We don't use the exit code when there is an error now.
There was a problem hiding this comment.
right.. just trying to figure out if that's on purpose. Seems at least possible to have an exit code and an error. Not a fan of throwing it out unless we need to.
| @@ -84,6 +86,8 @@ type criContainerdService struct { | |||
| // imageStoreService is the containerd service to store and track | |||
| // image metadata. | |||
| imageStoreService images.Store | |||
| // eventsService is the containerd task service client | |||
There was a problem hiding this comment.
just curious why this one is better up here?
There was a problem hiding this comment.
Just group containerd services together. No particular reason. :)
pkg/server/service.go
Outdated
| return c, nil | ||
| } | ||
|
|
||
| func (c *criContainerdService) Start() { | ||
| c.startEventMonitor() | ||
| go func() { | ||
| if err := c.streamServer.Start(true); err != nil { | ||
| glog.Errorf("Failed to start streaing server: %v", err) |
Signed-off-by: Lantao Liu <lantaol@google.com>
Random-Liu
force-pushed
the
support-container-streaming
branch
from
d30058f
to
4421cab
Compare
|
@mikebrow Addressed comments. |
Signed-off-by: Lantao Liu <lantaol@google.com>
Signed-off-by: Lantao Liu <lantaol@google.com>
Random-Liu
force-pushed
the
support-container-streaming
branch
from
4421cab
to
75731c8
Compare
42 tasks
lanchongyizu
pushed a commit
to lanchongyizu/cri-containerd
that referenced
this pull request
Sep 3, 2017
…treaming Add container Exec support.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Execsupport.ExecCRI validation test./cc @kubernetes-incubator/maintainers-cri-containerd