Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

FDQN is a typo, and we don't support trailing dot in FQDN. #1255

Merged
merged 1 commit into from
Aug 30, 2019
Merged

FDQN is a typo, and we don't support trailing dot in FQDN. #1255

merged 1 commit into from
Aug 30, 2019

Conversation

Random-Liu
Copy link
Member

FDQN is a typo.

And actually we are not supporting FQDN which requires a trailing dot.

Signed-off-by: Lantao Liu lantaol@google.com

@Random-Liu
FDQN is a typo, and we don't support trailing dot in FQDN.
2d03ccf 
Signed-off-by: Lantao Liu <lantaol@google.com>
@Random-Liu Random-Liu assigned Random-Liu and mikebrow and unassigned Random-Liu Aug 30, 2019
mikebrow
mikebrow approved these changes Aug 30, 2019
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jterry75
jterry75 approved these changes Aug 30, 2019
View reviewed changes
Copy link
Contributor

@jterry75 jterry75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Random-Liu
Copy link
Member Author

Apply LGTM based on #1255 (review) and #1255 (review)

@Random-Liu Random-Liu merged commit b5ec5ee into containerd:master Aug 30, 2019
@Random-Liu Random-Liu deleted the fix-doc branch August 30, 2019 21:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jterry75 jterry75 jterry75 approved these changes

@mikebrow mikebrow mikebrow approved these changes

Assignees

@mikebrow mikebrow

Labels
lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Random-Liu @jterry75 @mikebrow @k8s-ci-robot