Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

Fix privileged caps #518

Merged
merged 1 commit into from
Jan 3, 2018
Merged

Conversation

Random-Liu
Copy link
Member

Fixes #517.

We should enable the HostSpecific option, so that the generator will apply host specific cap list https://github.com/opencontainers/runtime-tools/blob/master/generate/generate.go#L1023.

Signed-off-by: Lantao Liu <lantaol@google.com>
@bmcustodio
Copy link

bmcustodio commented Jan 3, 2018

@Random-Liu thanks! Any chance this lands in a release anytime soon?

Copy link
Member

@abhi abhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense. LGTM

@pires
Copy link

pires commented Jan 3, 2018

Sweet! Yeah, a new release would definitely unblock us.

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@Random-Liu
Copy link
Member Author

Random-Liu commented Jan 3, 2018

@bmcstdio @pires I marked this v1.0.0-beta.1. I'll cut the patch release after we collect several bug fixes, probably next week. Is this OK to you?

We don't have a regular release schedule now, mainly because we plan to do a refactoring to make cri-containerd easier for user to use containerd/containerd#1942. We'll start matching Kubernetes release after 1.0.0.

@Random-Liu Random-Liu merged commit 5b82e3a into containerd:master Jan 3, 2018
@Random-Liu Random-Liu deleted the fix-privileged-caps branch January 3, 2018 20:00
@Random-Liu
Copy link
Member Author

@pires @bmcstdio It would be super helpful if you could verify whether this fixes your issue. We don't have a test environment for CentOS today.

@pires
Copy link

pires commented Jan 3, 2018

@Random-Liu we are doing so and will report tomorrow morning GMT time.

re: v1.0.0-beta.1 cut, works for us as we are not blocked by it anymore - we can run our build for the time being as we're just testing it to replace our current Docker setup. Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants