-
Notifications
You must be signed in to change notification settings - Fork 350
Conversation
Signed-off-by: Lantao Liu <lantaol@google.com>
f13d72f
to
31bc964
Compare
@Random-Liu thanks! Any chance this lands in a release anytime soon? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sense. LGTM
Sweet! Yeah, a new release would definitely unblock us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
@bmcstdio @pires I marked this v1.0.0-beta.1. I'll cut the patch release after we collect several bug fixes, probably next week. Is this OK to you? We don't have a regular release schedule now, mainly because we plan to do a refactoring to make cri-containerd easier for user to use containerd/containerd#1942. We'll start matching Kubernetes release after 1.0.0. |
@pires @bmcstdio It would be super helpful if you could verify whether this fixes your issue. We don't have a test environment for CentOS today. |
@Random-Liu we are doing so and will report tomorrow morning GMT time. re: v1.0.0-beta.1 cut, works for us as we are not blocked by it anymore - we can run our build for the time being as we're just testing it to replace our current Docker setup. Thank you! |
Fixes #517.
We should enable the
HostSpecific
option, so that the generator will apply host specific cap list https://github.com/opencontainers/runtime-tools/blob/master/generate/generate.go#L1023.