This repository has been archived by the owner on Mar 9, 2022. It is now read-only.
Fix hostname env. #901
Merged
Fix hostname env. #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice; thanks @Random-Liu |
|
We should cherrypick this into all supported branches. |
Signed-off-by: Lantao Liu <lantaol@google.com>
Random-Liu
force-pushed
the
fix-hostname-env
branch
from
be5c984
to
f08a90f
Compare
|
/lgtm |
|
I'll cherrypick this one after it is proved that this PR doesn't break e2e test. |
This was referenced Sep 10, 2018
Random-Liu
added a commit
that referenced
this pull request
Sep 11, 2018
Cherrypick #901 to release/1.0
Random-Liu
added a commit
that referenced
this pull request
Sep 11, 2018
Cherrypick #901 to release/1.11
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #898 (comment)
Add
HOSTNAMEback. /cc @estespSigned-off-by: Lantao Liu lantaol@google.com