Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Go modules instead of vndr #50

Merged
merged 3 commits into from Nov 21, 2019
Merged

Use Go modules instead of vndr #50

merged 3 commits into from Nov 21, 2019

Conversation

kzys
Copy link
Member

@kzys kzys commented Nov 21, 2019

Based on containerd/project#25 and to someday support containerd/containerd#3182, this change moves go-cni from vndr to Go modules.

Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
@codecov-io
Copy link

codecov-io commented Nov 21, 2019

Codecov Report

Merging #50 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #50   +/-   ##
=======================================
  Coverage   42.29%   42.29%           
=======================================
  Files           8        8           
  Lines         357      357           
=======================================
  Hits          151      151           
  Misses        176      176           
  Partials       30       30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d20b7ee...7332d8a. Read the comment docs.

Copy link
Member

@mxpv mxpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 60d1252 into containerd:master Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants